Skip to content

Comments

fix(device notifications): fall back to default announcer if announcerIdentity not registered#776

Merged
lismith2-cisco merged 1 commit intomomentum-design:masterfrom
lismith2-cisco:SPARK-635490-announcer-fallback
Mar 27, 2025
Merged

fix(device notifications): fall back to default announcer if announcerIdentity not registered#776
lismith2-cisco merged 1 commit intomomentum-design:masterfrom
lismith2-cisco:SPARK-635490-announcer-fallback

Conversation

@lismith2-cisco
Copy link
Collaborator

@lismith2-cisco lismith2-cisco commented Mar 26, 2025

Description

  • Add isRegistered function to ScreenReaderAnnouncer
  • NotificationSystem falls back to its default announcer if announcerIdentity isn't registered, with a warning, to avoid losing notifications to timing issues.

Links

jira: https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-635490
original momentum PR: #773
accompanying cantina PR: https://sqbu-github.cisco.com/WebExSquared/webex-web-client/pull/7881

@lismith2-cisco lismith2-cisco added the validated If the pull request is validated automation. label Mar 26, 2025
@lismith2-cisco lismith2-cisco merged commit 95c1521 into momentum-design:master Mar 27, 2025
9 of 10 checks passed
@github-actions
Copy link

🎉 This PR is included in version 26.201.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released validated If the pull request is validated automation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants